Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit.ci] pre-commit autoupdate #1069

Merged
merged 2 commits into from
Feb 5, 2024
Merged

[pre-commit.ci] pre-commit autoupdate #1069

merged 2 commits into from
Feb 5, 2024

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jan 22, 2024 •
edited
Loading

@pre-commit-ci pre-commit-ci bot requested a review from a team as a code owner January 22, 2024 18:28
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from d42f8d2 to 9591c29 Compare January 29, 2024 18:38
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
3883a08 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.1.13 → v0.2.0](astral-sh/ruff-pre-commit@v0.1.13...v0.2.0)
- [github.com/psf/black: 23.12.1 → 24.1.1](psf/black@23.12.1...24.1.1)
- [github.com/PyCQA/bandit: 1.7.6 → 1.7.7](PyCQA/bandit@1.7.6...1.7.7)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from dc1fa65 to 3883a08 Compare February 5, 2024 18:30
@codecov Codecov
Copy link

codecov bot commented Feb 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.80%. Comparing base (f61ff4e) to head (15e3f8f).
Report is 439 commits behind head on main.

Files Patch % Lines
romancal/dark_current/dark_current_step.py 0.00% 1 Missing ⚠️
romancal/source_detection/source_detection_step.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1069      +/-   ##
==========================================
- Coverage   76.81%   76.80%   -0.02%     
==========================================
  Files         105      105              
  Lines        7035     7035              
==========================================
- Hits         5404     5403       -1     
- Misses       1631     1632       +1
Flag Coverage Δ *Carryforward flag
nightly 62.99% <ø> (-0.01%) ⬇️ Carriedforward from f61ff4e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamJamieson
Copy link
Collaborator

Ran the regression tests to be sure all these changes were fine: https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/590/.

@WilliamJamieson WilliamJamieson merged commit 79293f3 into main Feb 5, 2024
29 of 30 checks passed
@WilliamJamieson WilliamJamieson deleted the pre-commit-ci-update-config branch February 5, 2024 19:53
mairanteodoro pushed a commit to mairanteodoro/romancal that referenced this pull request Feb 14, 2024
@pre-commit-ci @mairanteodoro
[pre-commit.ci] pre-commit autoupdate (spacetelescope#1069)
d83e4d6 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamJamieson WilliamJamieson WilliamJamieson approved these changes

Assignees
No one assigned
Labels
assign_wcs associations Dark Current dq_init jump linearity Photom pipeline ramp_fitting regression_testing Saturation stpipe testing Wide Field Instrument (WFI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@WilliamJamieson